Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS-4] Share table for same input data across jobs #21

Merged
merged 3 commits into from
Jan 9, 2018
Merged

[JS-4] Share table for same input data across jobs #21

merged 3 commits into from
Jan 9, 2018

Conversation

wynot12
Copy link
Contributor

@wynot12 wynot12 commented Jan 8, 2018

Resolves #4.

This PR

  • uses InputPath as an identifier of input data table.
  • different jobs that use the same input data share the input table, as a result.

@wynot12 wynot12 mentioned this pull request Jan 8, 2018
Open
yunseong
yunseong approved these changes Jan 9, 2018
View reviewed changes
Copy link
Contributor

@yunseong yunseong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll merge if tests pass (triggered by a minor modification)

@yunseong yunseong merged commit ab2d44b into master Jan 9, 2018
@yunseong yunseong deleted the table-sharing branch January 9, 2018 14:54
@wynot12 wynot12 mentioned this pull request Feb 21, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunseong yunseong yunseong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wynot12 @yunseong