ISSUE-4: Word counter with one generator and one aggregator #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| import java.net.SocketAddress; | ||
|
|
||
| public class WordCountLinkListener implements LinkListener<Message<String>> { |
|
I've done a pass here. Let me know when you address the comments. |
|
Thank you for comments! I'll address them on Monday. |
|
I addressed all @DifferentSC's comments, except one. I think we can discuss the comment face to face. Thank you! |
|
Thank you for your code. Let's move on to the next step and register needed issues. |
DifferentSC
added a commit
that referenced
this pull request
Oct 5, 2015
ISSUE-4: Word counter with one generator and one aggregator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #4.
As a sub-issue of #1, I implement simple Word Counter REEF app with one generator and one aggregator.
The generator and the aggregator communicate using
NCS.@DifferentSC The base branch of this PR is not the master branch.
But it is my first REEF application and I think this app contains some mistakes although I try to learn and follow the REEF coding style. So I'll appreciate if you review this code when you have time on your hands. Thank you!
(FIY, I already copied
checkstyle.xmlin REEF project to this app and check my code using it.)