Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move custom API endpoint warning message to stderr #1331

Merged
merged 1 commit into from
Aug 18, 2020
Merged

fix: move custom API endpoint warning message to stderr #1331

merged 1 commit into from
Aug 18, 2020

Conversation

snykerjames
Copy link
Contributor

@snykerjames snykerjames commented Aug 13, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Changes the output stream for the "Using a custom API endpoint..." warning message from stdout to stderr.

Where should the reviewer start?

src/lib/config.ts: line 33

How should this be manually tested?

test with snyk-to-html using

$ snyk test --json | snyk-to-html

Any background context you want to provide?

This message currently outputs to stdout, which when running snyk with --json, breaks tools like snyk-to-html that require valid json input

What are the relevant tickets?

N/A

Screenshots

Before change:
image

After change:
image

Additional questions

I didn't find an existing test for this, so would be happy to add one with your guidance.

@snykerjames snykerjames requested review from a team as code owners August 13, 2020 20:49
@CLAassistant
Copy link

CLAassistant commented Aug 13, 2020

CLA assistant check
All committers have signed the CLA.

@ghost ghost requested review from dkontorovskyy and gitphill August 13, 2020 20:49
Copy link
Contributor

@gitphill gitphill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@JackuB JackuB merged commit 027d194 into snyk:master Aug 18, 2020
@snyksec
Copy link

snyksec commented Aug 18, 2020

🎉 This PR is included in version 1.377.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants