Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/revert container static scanning #1456

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Feat/revert container static scanning #1456

merged 2 commits into from
Oct 9, 2020

Conversation

ivanstanev
Copy link
Contributor

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Reverts recent changes that introduced container static scanning, but were also breaking the snyk CLI.

@ivanstanev
fix: Revert updating Docker plugin name
905c33d 
This reverts commit 188f370, reversing
changes made to bf32c4c.
@ivanstanev
fix: Revert releasing container static scanning
4fea3dd 
This reverts commit bf32c4c, reversing
changes made to acce1b2.
@ivanstanev ivanstanev requested review from a team as code owners October 9, 2020 16:08
@ivanstanev ivanstanev self-assigned this Oct 9, 2020
@ghost ghost requested review from aviadhahami and orsagie October 9, 2020 16:09
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2020

Warnings
⚠️

Looks like you added a new Tap test. Consider making it a Jest test instead. See files like test/*.spec.ts for examples. Files found:

Generated by 🚫 dangerJS against 4fea3dd

@ivanstanev ivanstanev linked an issue Oct 9, 2020 that may be closed by this pull request
[🐛] Cannot find module 'legacy-snyk-docker-plugin' #1453
Closed
@JackuB JackuB closed this Oct 9, 2020
@JackuB JackuB reopened this Oct 9, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2020 •
edited by ivanstanev

Expected release notes (by @JackuB)

fixes:
Revert releasing container static scanning (4fea3dd)
Revert updating Docker plugin name (905c33d)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@JackuB JackuB merged commit 8da62ca into master Oct 9, 2020
@JackuB JackuB deleted the feat/revert-container-static-scanning branch October 9, 2020 16:36
@snyksec
Copy link

snyksec commented Oct 9, 2020

🎉 This PR is included in version 1.413.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Sep 15, 2021
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jan 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackuB JackuB JackuB approved these changes

@aviadhahami aviadhahami Awaiting requested review from aviadhahami

@orsagie orsagie Awaiting requested review from orsagie

Assignees

@ivanstanev ivanstanev

Labels
released
Projects
None yet
Milestone
No milestone
3 participants
@ivanstanev @snyksec @JackuB