Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade danger-js #2347

Merged
2 commits merged into from
Nov 9, 2021
Merged

chore: upgrade danger-js #2347

2 commits merged into from
Nov 9, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 8, 2021

Noticed our DangerJS GitHub Action is old and out of sync with the one we use to write our scripts. So I've synced them and upgraded the version to latest. No breaking changes AFAIK.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2021

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 9ce752a

@ghost ghost marked this pull request as ready for review November 8, 2021 17:26
@ghost ghost requested review from a team as code owners November 8, 2021 17:26
@JackuB
Copy link
Contributor

JackuB commented Nov 9, 2021

There is some extra output compared to the usual output like on this other PR, but the Danger message gets posted:

2021-11-08T17:20:02.6037030Z Found only messages, passing those to review.
2021-11-08T17:20:02.7911515Z Request failed [403]: https://api.github.com/user
2021-11-08T17:20:02.7921460Z Response: {
2021-11-08T17:20:02.7922034Z   "message": "Resource not accessible by integration",
2021-11-08T17:20:02.7923894Z   "documentation_url": "https://docs.github.com/rest/reference/users#get-the-authenticated-user"
2021-11-08T17:20:02.7925152Z }
2021-11-08T17:20:03.4162895Z Request failed [403]: https://api.github.com/user
2021-11-08T17:20:03.4173074Z Response: {
2021-11-08T17:20:03.4173761Z   "message": "Resource not accessible by integration",
2021-11-08T17:20:03.4175964Z   "documentation_url": "https://docs.github.com/rest/reference/users#get-the-authenticated-user"
2021-11-08T17:20:03.4176865Z }
2021-11-08T17:20:05.0112275Z Feedback: https://github.com/snyk/snyk/pull/2347#issuecomment-963384690

@ghost
Copy link
Author

ghost commented Nov 9, 2021

Tempted to drop the custom action and use manual steps instead with a call to npx danger. Their action is using Node 12 and limits what we can do in terms of imports, TypeScript support, etc.

https://github.com/danger/danger-js/blob/10.7.1/source/ci_source/providers/GitHubActions.ts

@ghost ghost force-pushed the chore/upgrade-dangerjs branch from ad8b8dc to 9ce752a Compare November 9, 2021 12:27
@ghost
Copy link
Author

ghost commented Nov 9, 2021

Those 403 errors seem to be related to this: danger/danger-js#1031

@ghost ghost force-pushed the chore/upgrade-dangerjs branch from 411eeed to 9ce752a Compare November 9, 2021 12:36
@ghost
Copy link
Author

ghost commented Nov 9, 2021

Looks like the newer versions edit the existing message rather than delete and re-post new ones (causing notification spam). Nice.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant