chore(ci): reduce resource class #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These jobs utilise less than 50% of a large's resource. It's a waste. Go back to default (medium).
ghost
force-pushed
the
chore/reduce-resource-class
branch
from
0a78bbf
to
4a5b22d
Compare
ghost
marked this pull request as ready for review
maxjeffos
approved these changes
Jan 4, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These jobs utilise less than 50% of a large's resource. It's a waste. Go back to default (medium). For numbers see the "Resources" tab for any job in CircleCI.
I had to add
runInBandfor some of our Jest "package" tests to avoid timeouts.https://app.circleci.com/pipelines/github/snyk/snyk/8808/workflows/00296f85-f15c-4135-b74b-46a2ce284b0a/jobs/67106
So this could be why we setup "large" resources. "medium" can't handle parallel tests. However, I think adding "runInBand" is fine for now. We do it for other tests too so it's consistent. For parallelism, CircleCI has its own feature which would be a better fit here (see #2232)
To Do