feat: sha256 checksums for binary releases #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrukh
reviewed
Dec 5, 2018
.releaserc
Outdated
| @@ -3,7 +3,7 @@ | |||
| "@semantic-release/npm", | |||
| { | |||
| "path": "@semantic-release/exec", | |||
| "cmd": "npm i -g pkg && pkg ." | |||
| "cmd": "npm i -g pkg && pkg . && shasum -a 256 snyk-linux > snyk-linux.sha256 && shasum -a 256 snyk-macos > snyk-macos.sha256 && shasum -a 256 snyk-win.exe > snyk-win.exe.sha25" | |||
There was a problem hiding this comment.
right! I remember saying to myself "add a 6 after you paste" 😅 thanks ! 🙏
There was a problem hiding this comment.
sha25 is probably secure too !
|
I'll also verify now that the |
With this, sha256 checksums will be computed for the binary packages of the CLI and will be uploaded together with the binaries as release assets to GitHub, and will be named as `snyk-<platform>.sha256`.
michael-go
force-pushed
the
feat/checksum-binary-releases
branch
from
37a2f2c
to
0b13a04
Compare
|
cool - |
darscan
approved these changes
Dec 5, 2018
michael-go
added a commit
that referenced
this pull request
Dec 5, 2018
introduced in previous PR: #293
|
🎉 This PR is included in version 1.115.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Nov 24, 2020
This was referenced Sep 12, 2021
This was referenced Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, sha256 checksums will be computed for the binary packages of the CLI and will be uploaded together with the binaries as release assets to GitHub, and will be named as
snyk-<platform>.sha256.