Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove white texts from IaC test output #3416

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

ofekatr
Copy link
Contributor

@ofekatr ofekatr commented Jun 28, 2022

What does this PR do?

  • Changes white texts in the new IaC test output to be in the CLI's default text color.

Where should the reviewer start?

src/lib/formatters/iac-output/v2/utils.ts

How should this be manually tested?

  • Ensure the test output hasn't changed apart from white texts being converted to texts in the default color.
  • Using a terminal with a bright bg, ensure all texts are visible.
  • Using a terminal with a dark bg, ensure all texts are visible.

Any background context you want to provide?

  • At the moment, users with a light terminal background will not be able to see most of the headers in our output.

What are the relevant tickets?

  • No tickets.

Screenshots

Before:

image

image

After:

image

image

Additional information

@github-actions
Copy link
Contributor

Warnings
⚠️

You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against b9705eb

@ofekatr ofekatr marked this pull request as ready for review June 28, 2022 10:51
@ofekatr ofekatr requested a review from a team as a code owner June 28, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants