Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Release Extensible CLI via npm #4383

Merged
merged 1 commit into from
Feb 8, 2023
Merged

feat: Release Extensible CLI via npm #4383

merged 1 commit into from
Feb 8, 2023

Conversation

PeterSchafer
Copy link
Collaborator

What does this PR do?

Publishing a thin TS Wrapper for the Golang based Extensible CLI to NPM, as a replacement for the previously published TS CLI.

@PeterSchafer PeterSchafer marked this pull request as ready for review February 3, 2023 16:06
@PeterSchafer PeterSchafer requested review from a team as code owners February 3, 2023 16:06
PeterSchafer
PeterSchafer commented Feb 6, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@PeterSchafer PeterSchafer force-pushed the feat/HEAD-57_ext_cli_to_npm branch 3 times, most recently from 9f50871 to 94f7055 Compare February 6, 2023 12:17
bastiandoetsch
bastiandoetsch reviewed Feb 7, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@PeterSchafer PeterSchafer force-pushed the feat/HEAD-57_ext_cli_to_npm branch 2 times, most recently from 5290a60 to d5c4bc4 Compare February 7, 2023 14:34
@PeterSchafer PeterSchafer reopened this Feb 7, 2023
michelkaporin
michelkaporin approved these changes Feb 8, 2023
View reviewed changes
ts-binary-wrapper/src/bootstrap.ts Outdated Show resolved Hide resolved
@PeterSchafer PeterSchafer force-pushed the feat/HEAD-57_ext_cli_to_npm branch 2 times, most recently from aca2111 to c56d9c2 Compare February 8, 2023 11:56
bastiandoetsch
bastiandoetsch approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@bastiandoetsch bastiandoetsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added the stack reporting to Sentry and did a minor reformat in basic.spec.ts

@PeterSchafer
feat: Release Extensible CLI via npm
f198761 
publishing a thin TS Wrapper for the Golang based Extensible CLI
@PeterSchafer PeterSchafer reopened this Feb 8, 2023
@PeterSchafer PeterSchafer merged commit 1c40a37 into master Feb 8, 2023
@PeterSchafer PeterSchafer deleted the feat/HEAD-57_ext_cli_to_npm branch February 8, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelkaporin michelkaporin michelkaporin approved these changes

@bastiandoetsch bastiandoetsch bastiandoetsch approved these changes

@aron aron Awaiting requested review from aron aron was automatically assigned from snyk/snyk-open-source

@dagrest dagrest Awaiting requested review from dagrest dagrest was automatically assigned from snyk/snyk-open-source

@JamesPatrickGill JamesPatrickGill Awaiting requested review from JamesPatrickGill JamesPatrickGill was automatically assigned from snyk/snyk-open-source

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterSchafer @michelkaporin @bastiandoetsch