feat: npm lock v2 and v3 support #4401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesPatrickGill
requested review from
klesniewski,
dotkas and
alexandru-dragomir
JamesPatrickGill
force-pushed
the
feat/npm-lock-v2-and-v3-support
branch
11 times, most recently
from
df425af
to
8ea0b4f
Compare
admons
previously approved these changes
Feb 14, 2023
JamesPatrickGill
force-pushed
the
feat/npm-lock-v2-and-v3-support
branch
from
8ea0b4f
to
d8c0665
Compare
JamesPatrickGill
force-pushed
the
feat/npm-lock-v2-and-v3-support
branch
from
d8c0665
to
920cb69
Compare
5 tasks
JamesPatrickGill
force-pushed
the
feat/npm-lock-v2-and-v3-support
branch
2 times, most recently
from
a133c49
to
25def97
Compare
orsagie
reviewed
Feb 27, 2023
orsagie
approved these changes
Feb 27, 2023
JamesPatrickGill
force-pushed
the
feat/npm-lock-v2-and-v3-support
branch
2 times, most recently
from
3ef807a
to
17f44d3
Compare
PeterSchafer
approved these changes
Feb 28, 2023
admons
reviewed
Mar 6, 2023
JamesPatrickGill
force-pushed
the
feat/npm-lock-v2-and-v3-support
branch
2 times, most recently
from
228780c
to
138388b
Compare
|
This PR is dependent on the new version of nodejs-lockfile-parser that will be published by this PR snyk/nodejs-lockfile-parser#182 |
JamesPatrickGill
force-pushed
the
feat/npm-lock-v2-and-v3-support
branch
4 times, most recently
from
6511e07
to
b393ab2
Compare
JamesPatrickGill
force-pushed
the
feat/npm-lock-v2-and-v3-support
branch
from
b393ab2
to
bf7c8c1
Compare
JamesPatrickGill
force-pushed
the
feat/npm-lock-v2-and-v3-support
branch
from
bf7c8c1
to
921d41b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds cli support for
package-lockversions 2 and 3. These versions have been in use since npm7.Previous support for npm-lock-v2 exists but was using older
dep-treelogic. This PR also upgrades this to use dep-graph solely.