Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update snyk-ls [IDE-172] #5100

Merged
merged 1 commit into from
Mar 18, 2024
Merged

feat: update snyk-ls [IDE-172] #5100

merged 1 commit into from
Mar 18, 2024

Conversation

teodora-sandu
Copy link
Contributor

@teodora-sandu teodora-sandu commented Mar 11, 2024

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Review

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What the PR does

Updates snyk-ls to the latest release which contains some refactoring and also an update to use code-client-go and return fake Snyk Code ignores behind a feature flag.

This is part of some refactoring work.

What are the relevant tickets?

https://snyksec.atlassian.net/browse/IDE-175

@teodora-sandu teodora-sandu requested a review from a team as a code owner March 11, 2024 10:29
@teodora-sandu teodora-sandu changed the title refactor: update snyk-ls to use issue enhances [IDE-175] refactor: update snyk-ls [IDE-175] Mar 12, 2024
@teodora-sandu teodora-sandu changed the title refactor: update snyk-ls [IDE-175] refactor: update snyk-ls [IDE-175] [IDE-172] Mar 12, 2024
@teodora-sandu teodora-sandu force-pushed the refactor/issue-enhancer branch 4 times, most recently from 4e3a348 to 918ca83 Compare March 12, 2024 15:44
@teodora-sandu teodora-sandu changed the title refactor: update snyk-ls [IDE-175] [IDE-172] feat: update snyk-ls [IDE-175] [IDE-172] Mar 12, 2024
@teodora-sandu teodora-sandu force-pushed the refactor/issue-enhancer branch 6 times, most recently from 854bbf2 to 31c35d4 Compare March 15, 2024 09:37
@teodora-sandu teodora-sandu reopened this Mar 15, 2024
@teodora-sandu teodora-sandu changed the title feat: update snyk-ls [IDE-175] [IDE-172] feat: update snyk-ls [IDE-172] Mar 15, 2024
@teodora-sandu teodora-sandu enabled auto-merge (squash) March 18, 2024 14:52
@teodora-sandu teodora-sandu merged commit c9cc908 into main Mar 18, 2024
14 checks passed
@teodora-sandu teodora-sandu deleted the refactor/issue-enhancer branch March 18, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants