fix: make download of CLI in language server more resilient under windows [IDE-90]

[bastiandoetsch]

Pull Request Submission

Please check the boxes once done.

The pull request must:

• Reviewer Documentation
  • follow CONTRIBUTING rules
  • be accompanied by a detailed description of the changes
  • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
  • highlight breaking API if applicable
  • contain a link to the automatic tests that cover the updated functionality.
  • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
  • link to the link to the PR for the User-facing documentation
• User facing Documentation
  • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
  • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
• Testing
  • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What does this PR do?

This PR pulls in the latest version of Language Server, which addresses:

• better download of the CLI binary with more resiliency under Windows
• new code-client-go version (1.3.0)

Risk: Low

Where should the reviewer start?

Tests: https://github.com/snyk/snyk-ls/actions/runs/8596179978/job/23552249205
Original PR: snyk/snyk-ls#481

How should this be manually tested?

Build the CLI for Windows, and startup VSCode under Windows, pointing at the compiled version of CLI.

Any background context you want to provide?

Updating the CLI did not always work under Windows, as the temporary download directory was independent of the destination directory, which could cause problems moving the file across Windows drives, and also with different permissions. Now the temp download file is created below the target directory, so the same permissions apply. Also, moving it cannot cross drives anymore.

What are the relevant tickets?

IDE-90

Screenshots

Additional questions

[github-actions]

	Warnings
⚠️	"fix: make download of CLI in language server more resilient under windows [IDE-90]" is too long. Keep the first line of your commit message under 72 characters.

Generated by 🚫 dangerJS against 7b31a21