Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(language-server): add --all-projects flag scans by default [IDE-318] #5247

Merged
merged 1 commit into from
May 27, 2024

Conversation

bastiandoetsch
Copy link
Contributor

@bastiandoetsch bastiandoetsch commented May 21, 2024

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

What does this PR do?

  • bumps LS to the latest release version

releases since last update

Where should the reviewer start?

Link above with the comparison.

How should this be manually tested?

Build and launch VSCode.

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner May 21, 2024 12:15
@bastiandoetsch bastiandoetsch marked this pull request as draft May 21, 2024 12:19
@bastiandoetsch bastiandoetsch force-pushed the feat/IDE-318_default-to-all-projects-oss-scans branch from 99625af to bfd34eb Compare May 21, 2024 12:23
@bastiandoetsch bastiandoetsch marked this pull request as ready for review May 21, 2024 12:23
@bastiandoetsch bastiandoetsch changed the title feat(ls): add --all-projects flag to open source scans by default feat(language-server): add --all-projects flag to open source scans by default May 24, 2024
@bastiandoetsch bastiandoetsch changed the title feat(language-server): add --all-projects flag to open source scans by default feat(language-server): add --all-projects flag scans by default [IDE-318] May 24, 2024
@PeterSchafer PeterSchafer force-pushed the feat/IDE-318_default-to-all-projects-oss-scans branch from bfd34eb to 288b694 Compare May 27, 2024 12:42
@PeterSchafer PeterSchafer force-pushed the feat/IDE-318_default-to-all-projects-oss-scans branch from 288b694 to 59e5a29 Compare May 27, 2024 13:31
@PeterSchafer PeterSchafer enabled auto-merge (squash) May 27, 2024 13:32
@PeterSchafer PeterSchafer merged commit fdcf30e into main May 27, 2024
15 checks passed
@PeterSchafer PeterSchafer deleted the feat/IDE-318_default-to-all-projects-oss-scans branch May 27, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants