Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test execution failed on darwin #65

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Conversation

eliecharra
Copy link
Contributor

Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #60
❓ Documentation no

Description

Fix hardcoded linux_amd64 hardcoded values in test expectations

@eliecharra eliecharra added the kind/maintenance Refactoring or changes to the workspace label Jan 5, 2021
@eliecharra eliecharra added this to the v0.2.0 milestone Jan 5, 2021
@eliecharra eliecharra requested a review from wbeuil January 5, 2021 13:40
@eliecharra eliecharra requested a review from a team as a code owner January 5, 2021 13:40
@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #65 (88b1379) into main (a0f61c2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage   67.51%   67.51%           
=======================================
  Files         146      146           
  Lines        3245     3245           
=======================================
  Hits         2191     2191           
  Misses        811      811           
  Partials      243      243           

Copy link
Contributor

@wbeuil wbeuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm !

@eliecharra eliecharra linked an issue Jan 5, 2021 that may be closed by this pull request
@eliecharra eliecharra merged commit e91b00d into main Jan 5, 2021
@eliecharra eliecharra deleted the fix_test_on_darwin branch January 5, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test "TestProviderInstallerGetAwsDoesNotExist" failed on macOS
2 participants