Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement plugin using Kotlin and Gradle incremental build APIs #17

Closed
wants to merge 23 commits into from

Conversation

adam-dpg
Copy link
Contributor

@adam-dpg adam-dpg commented May 5, 2022

Work in progress!

You can already use this release - see the README here

Depends on #16

Resolves #4
Resolves #5
Resolves #6
Resolves #7
Resolves #8
Resolves #11
Resolves #13
Resolves #14

TODO

  • up-to-date check on the CLI version
  • Tests
  • Add KDoc to extension properties
  • Add KDoc to task properties

@svenXY
Copy link

svenXY commented Jun 6, 2024

Hi, I have a problem with the plugin which is described there: https://discuss.gradle.org/t/kotlin-task-in-8-8-suddenly-fails-due-to-wrong-directory/48618.

The plugin assumes that ...

the Project directory is the current user working directory.
This was never guaranteed and also is not always the case even before 8.8.

It often is the case, but it can be the daemon directory, it can be the IDE installation directory, …

There is no guarantee what the current user working directory is, and any Gradle plugin that assumes this has a bug that just waits for blowing off."

And this is indeed the case with gradle 8.8 - after starting the daemon, the working directory is not the build directory, but $GRADLE_HOME/daemon/8.8 and there the snyk plugin of course cannot find any files to analyse.

According to a comment from a seasoned gradle user, your MR seems to fix it: https://discuss.gradle.org/t/kotlin-task-in-8-8-suddenly-fails-due-to-wrong-directory/48618/3?u=svenxy .

Any chance you bring this up again and have it merged?

Otherwise we would have to stop using it in our CI pipeline and migrate to a commandline-only version

@bmvermeer
Copy link
Collaborator

closing since this is a draft since 2022

@bmvermeer bmvermeer closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment