-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implement plugin using Kotlin and Gradle incremental build APIs #17
Conversation
- bump Gradle version - bump Gradle plugin publish (remove need for plugin .properties file) - enable Gradle caching - migrate build logic to Kotlin - replace 'functional-test' Gradle config with jvm-test-suite gradle plugin - set up buildSrc for shared build logic
Hi, I have a problem with the plugin which is described there: https://discuss.gradle.org/t/kotlin-task-in-8-8-suddenly-fails-due-to-wrong-directory/48618. The plugin assumes that ...
And this is indeed the case with gradle 8.8 - after starting the daemon, the working directory is not the build directory, but $GRADLE_HOME/daemon/8.8 and there the snyk plugin of course cannot find any files to analyse. According to a comment from a seasoned gradle user, your MR seems to fix it: https://discuss.gradle.org/t/kotlin-task-in-8-8-suddenly-fails-due-to-wrong-directory/48618/3?u=svenxy . Any chance you bring this up again and have it merged? Otherwise we would have to stop using it in our CI pipeline and migrate to a commandline-only version |
closing since this is a draft since 2022 |
Work in progress!
You can already use this release - see the README here
Depends on #16
Property<>
s andProvider<>
s to make the plugin compatible with the Gradle build and configuration caches https://docs.gradle.org/current/userguide/configuration_cache.htmlResolves #4
Resolves #5
Resolves #6
Resolves #7
Resolves #8
Resolves #11
Resolves #13
Resolves #14
TODO