fix: UBI9 image build [CIT-518] #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnyowenpowell
force-pushed
the
fix/ubi9-image-build
branch
from
e4d714c
to
c3ba22a
Compare
jonnyowenpowell
force-pushed
the
fix/ubi9-image-build
branch
2 times, most recently
from
837debf
to
9a2d7da
Compare
jonnyowenpowell
force-pushed
the
fix/ubi9-image-build
branch
8 times, most recently
from
e2eb7e5
to
b48dcc7
Compare
iuliams
reviewed
Aug 22, 2023
jonnyowenpowell
force-pushed
the
fix/ubi9-image-build
branch
from
b7bfa78
to
293a2e0
Compare
iuliams
approved these changes
Aug 23, 2023
|
🎉 This PR is included in version 2.4.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This PR improves the installation and verification of dependencies in the UBI9 image build.
Dependency installation via package managers or builds from source have been replaced by binary downloads. Binaries are downloaded with
curls-f (--fail)set, and hashes of the downloaded files are checked before continuing the build. A notable exception isgcloud, the Google Cloud CLI, which continues to be installed via their provided script. Python 3 is no longer explicitly installed, and instead we allowgcloudto install its bundled version of Python.The application is now built using the
ubi8/nodejs-16base image, to align more closely with the production container's base image. Due to the age of Node.js 16, a UBI9 base image is not available. When this project updates to use Node.js 18, we can build using theubi9/nodejs-18image, achieving complete alignment with the production container's base image.Platforms are explicitly set to
linux/amd64for both build stages, to ensure that developer's machine architecture does not affect the image being built.Notes for the reviewer
This resolves a couple of issues:
libdevmapper