Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update email-validator #20

Merged
merged 1 commit into from
Apr 17, 2018
Merged

update email-validator #20

merged 1 commit into from
Apr 17, 2018

Conversation

joshje
Copy link
Contributor

@joshje joshje commented Apr 17, 2018

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by @remy (Snyk internal team)

What does this PR do?

In order to maintain compatibility with Node 0.12, we need to pin email-validator to the version that supports this version of Node.

There's a new major version release that we'd like to use. This new version requires Node>=4

@joshje joshje self-assigned this Apr 17, 2018
@joshje joshje requested a review from darscan April 17, 2018 13:59
Copy link

@darscan darscan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't stay stuck in the past :(

let's upgrade to latest and drop 0.12 from our cli (we've been warning CLI users for months already, and we're way past the deadline (which was the 5th of March)

There's a new major version release that we'd like to use. This
new version requires Node>=4
@joshje joshje changed the title fix: later versions of email-validator don't support node 0.12 update email-validator Apr 17, 2018
@joshje joshje merged commit dfd2116 into master Apr 17, 2018
@joshje joshje deleted the fix/pin-email-validator branch April 17, 2018 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants