Default nested #388
Merged
Default nested #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to unpack a JAR to get the pom.dependencies in it, which we need to get shaded JARs. This commit: - makes the default level of unpacking JARs 1 (instead of 0) - unpacks the default level whenevet --app-vulns is provided, even if --nested-jars-depth was not - prohibits any attempt to not unpack at least 1 level (no 0)
shaninja
force-pushed
the
default-nested
branch
from
58231d4
to
6a81f89
Compare
michael-c-snyk
approved these changes
Dec 20, 2021
|
🎉 This PR is included in version 4.32.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Step #1 for detecting log4j automatically for customers who scan images with shaded and nested jars.
The end goal is to have always at least 1 level scanned,
see here https://www.notion.so/snyk/log4shell-shaded-Jar-detection-552bed54e8964a968867c601905f80a0#723610c656e7467684a6cbf62f84322d and here https://snyk.slack.com/archives/C01EPSKVC9L/p1639908202242500?thread_ts=1639765350.234600&cid=C01EPSKVC9L
The first step (in this PR) is making the default level of unpacking 1 (instead of 0, which it once was).
The second step would be to unpack 1 level more than what the customer requested, so we can get the pom.properties (the shaded jars) for that level of nesting.