-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: get correct project name #95
Conversation
07cf673
to
21739bd
Compare
21739bd
to
d65f7cf
Compare
0d67bf1
to
9a00db8
Compare
@sfat before you merge or release new CLI, please could you verify the project works as expected by doing:
|
@lili2311 I was wondering how to do that. |
3b981b8
to
1ad6feb
Compare
I've extended |
1ad6feb
to
8eb630b
Compare
I've talked yesterday with @miiila regarding the This will contain an array (maybe needed for multi level projects where you would have multiple names) of type map, where the key of the map is the old name and the value is the new name.
The reason for this change is that @miiila was saying that Again, let me know if this is okay or you have other ideas. |
related this this one: snyk/snyk-cli-interface#20 |
e3cd16f
to
2796543
Compare
a0fe7ce
to
fc122e4
Compare
fc122e4
to
b658f37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 nice!
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What does this PR do?
Fixes #93 . Problem was the project name was not being picked correctly.