Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add issue range to scan issues #443

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

bastiandoetsch
Copy link
Collaborator

Description

Adds range information to scanIssues transferred via the custom $/snyk.scan message. This enables clients to display a range without having to analyse the diagnostics notifications.

Checklist

  • Tests added and all succeed
  • Linted
  • README.md updated, if user-facing
  • License file updated, if new 3rd-party dependency is introduced

🚨After having merged, please update the CLI go.mod to pull in latest language server.

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

Copy link
Contributor

@cat2608 cat2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@bastiandoetsch bastiandoetsch merged commit 5c61976 into main Feb 12, 2024
13 checks passed
@bastiandoetsch bastiandoetsch deleted the chore/add-range-to-lsp-additional-data branch February 12, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants