chore: demonstrate issue w/failing rules and changes #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be able to introduce Optic into a project, it should only apply rules to changes between specs. This allows Optic to be introduced into a new project which may not yet conform to all the standards. New changes to specs must meet these standards, but existing specs should not fail CI. This change introduces a spec that violates naming conventions, which should fail if introduced as new (--to 000-fail-naming.yaml with no --from) but should pass if compared against itself (no change means no violating change).
|
Landed in rebased #126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to introduce Optic into a project, it should
only apply rules to changes between specs. This allows Optic to be
introduced into a new project which may not yet conform to all the
standards. New changes to specs must meet these standards, but existing
specs should not fail CI.
This change introduces a spec that violates naming conventions, which
should fail if introduced as new (--to 000-fail-naming.yaml with no
--from) but should pass if compared against itself (no change means no
violating change).