Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated embed.go is not gofmt'd #120

Closed
cmars opened this issue Jan 14, 2022 · 1 comment · Fixed by #123
Closed

Generated embed.go is not gofmt'd #120

cmars opened this issue Jan 14, 2022 · 1 comment · Fixed by #123
Assignees
@cmars

Comments

@cmars
Copy link
Contributor

cmars commented Jan 14, 2022

Checkstyle error shows:

  <file name="v3/versions/embed.go">
    <error column="0" line="1" message="File is not `gofmt`-ed with `-s`" severity="error" source="gofmt">
    </error>
    <error column="1" line="8" message="exported: comment on exported var Versions should be of the form &#34;Versions ...&#34;" severity="error" source="revive">
    </error>
  </file>

Need to check whether this is still affecting 3.x
@cmars
Copy link
Contributor Author

cmars commented Jan 14, 2022

It's currently affecting main (all versions). Confirmed.

@cmars cmars self-assigned this Jan 14, 2022
cmars added a commit to cmars/vervet that referenced this issue Jan 14, 2022
@cmars
fix: add godoc comment to generated embed.FS
c0fec12 
This adds a godoc comment to the generated embed.go which embeds the
compiled OpenAPI specs for compilation into a Go service.

Added a test to assert that the godoc comment does not interfere with
the //go:embed magic comments.

Fixes snyk#120.
@cmars cmars mentioned this issue Jan 14, 2022
Merged
cmars added a commit to cmars/vervet that referenced this issue Jan 14, 2022
@cmars
fix: fix gofmt and other linting on generated embed.FS
5618978 
This fixes gofmt and adds a godoc comment to the generated embed.go
which embeds the compiled OpenAPI specs for compilation into a Go
service.

Added a test to assert that the godoc comment does not interfere with
the //go:embed magic comments.

Added golangci-lint to the versionware examples and cleaned a few things
up.

Fixes snyk#120.
cmars added a commit to cmars/vervet that referenced this issue Jan 14, 2022
@cmars
fix: fix gofmt and other linting on generated embed.FS
e514427 
This fixes gofmt and adds a godoc comment to the generated embed.go
which embeds the compiled OpenAPI specs for compilation into a Go
service.

Added a test to assert that the godoc comment does not interfere with
the //go:embed magic comments.

Added golangci-lint to the versionware examples and cleaned a few things
up.

Fixes snyk#120.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmars cmars

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add godoc comment to generated embed.FS cmars/vervet
1 participant
@cmars