fix: disallow requesting API version dates in the future #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genslein
reviewed
Jan 21, 2022
cmars
force-pushed
the
fix/disallow-future-version
branch
from
835d5f1
to
a8d6378
Compare
genslein
approved these changes
Jan 21, 2022
|
Only good reason I can think of is fixing the clock in tests -- so I won't expose Today as a config option, I'll just make it patchable in this package's tests. |
Respond 400 when a version date is requested from the future.
cmars
force-pushed
the
fix/disallow-future-version
branch
from
a8d6378
to
d4319e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respond 400 when a version date is requested from the future.