fix: select correct architecture #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* switch name of output binaries to match node arch convention * add linux arm64 build * use process.arch to select correct bin
|
|
|
Thanks for this! Going to QA this locally, just to be sure the filename change doesn't disrupt releases, but it seems fine! |
cmars
approved these changes
Feb 24, 2022
There was a problem hiding this comment.
Thanks for this! QA of npm package dist on amd64 seems fine (was mainly concerned that the rename to x64 didn't cause any disruption).
Please sign the CLA (https://cla-assistant.io/snyk/vervet?pullRequest=151) so I can land & cut a release. Thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch name of output binaries to match node arch convention
add linux arm64 build
use process.arch to select correct bin