feat: custom generator functions in JS, test component templating #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Templating over the kin-openapi/openapi3 document object model is generally powerful enough to enumerate types in various languages, as the test in this PR demonstrates for Typescript. However, it's inevitable that such templates will need language-specific adaptation functions. Rather than try to include all those batteries in the provided builtin template functions, this PR adds support for generator function extension with Javascript. Note that goja is the same embedded JS engine used by Grafana k6.
cmars
force-pushed
the
feat/component-generation
branch
from
1daf6ff
to
23897b6
Compare
|
😮 This is super cool!!!!!!!!! (The test would be even cooler if it showed the integer -> number thing working 😛 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templating over the kin-openapi/openapi3 document object model is
generally powerful enough to enumerate types in various languages, as
the test in this PR demonstrates for Typescript.
However, it's inevitable that such templates will need language-specific
adaptation functions. Rather than try to include all those batteries in
the provided builtin template functions, this PR adds support for
generator function extension with Javascript.
Note that goja is the same embedded JS engine used by Grafana k6.