feat: VersionSlice supporting sort and search #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmars
force-pushed
the
feat/version-slice
branch
from
834cc72
to
d40f57c
Compare
Todai88
approved these changes
Oct 27, 2021
cmars
force-pushed
the
feat/version-slice
branch
from
d40f57c
to
c193b7e
Compare
Introducing a new VersionSlice type which exports Version sorting and searching capabilities for library reuse. Search is implemented as a binary search over a sorted slice for high-performance applications that need to resolve a larger collection of versions -- routing middleware, for example. Existing Spec and Resource APIs have been updated to use VersionSlice which breaks compatibility; this change will require a major semver bump when released.
cmars
force-pushed
the
feat/version-slice
branch
from
c193b7e
to
8b50886
Compare
genslein
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a new VersionSlice type which exports Version sorting and
searching capabilities for library reuse.
Search is implemented as a binary search over a sorted slice for
high-performance applications that need to resolve a larger collection
of versions -- routing middleware, for example.
Existing Spec and Resource APIs have been updated to use VersionSlice
which breaks compatibility; this change will require a major semver bump
when released.