Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Optic CI linter #73

Merged
merged 1 commit into from
Nov 23, 2021
Merged

feat: add Optic CI linter #73

merged 1 commit into from
Nov 23, 2021

Conversation

cmars
Copy link
Contributor

@cmars cmars commented Nov 22, 2021

Add support for linting OpenAPI spec file changes with Optic CI. This
linter operates on a comparison of two versions of the spec file, a
--from and --to version.

Files may be sourced from Git or a local working copy.

@cmars cmars requested a review from a team as a code owner November 22, 2021 14:52
@cmars cmars force-pushed the feat/optic-lint branch 6 times, most recently from 6349f65 to 8ecf205 Compare November 22, 2021 15:58
Copy link
Contributor

@jcsackett jcsackett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few questions/comments. 👍🏼

internal/optic/linter.go Outdated Show resolved Hide resolved
internal/optic/linter.go Outdated Show resolved Hide resolved
internal/optic/linter_test.go Show resolved Hide resolved
internal/optic/linter_test.go Outdated Show resolved Hide resolved
Add support for linting OpenAPI spec file changes with Optic CI. This
linter operates on a comparison of two versions of the spec file, a
--from and --to version.

Files may be sourced from Git or a local working copy.
@cmars cmars merged commit 4f5c271 into snyk:main Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants