Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oauth2 authentication method by default #520

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Conversation

Arvi3d
Copy link
Contributor

@Arvi3d Arvi3d commented Aug 26, 2024

Description

This PR removed all "experimental" notes about oauth2 authentication and makes it default.
Communications were done. This should go live on August 29.

SCR-20240826-lwkh

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@Arvi3d Arvi3d requested a review from a team as a code owner August 26, 2024 11:18
@Arvi3d Arvi3d requested review from a team and removed request for a team August 26, 2024 11:18
@ShawkyZ ShawkyZ added the ⚠️ DON'T MERGE Shouldn't be merged yet. label Aug 26, 2024
@Arvi3d Arvi3d removed the ⚠️ DON'T MERGE Shouldn't be merged yet. label Aug 28, 2024
@ShawkyZ ShawkyZ merged commit 69dc632 into main Aug 28, 2024
11 checks passed
@ShawkyZ ShawkyZ deleted the fix/oauth2-default branch August 28, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants