run CI in github actions #407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this still fail? I just ran okay on |
|
@paulirish what is the status on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got CI w/ github actions working. It runs linux, mac and windows. and I have it testing all the perl versions we had in travis (except
bleadanddev).linux certainly needed the same TERM=dumb hack we used elsewhere.
Generally I'm super happy with this and think this will allow us to stop using travis/ci/appveyor.
But.. there are 3 failures in Windows right now.
It seems that the test suite passes file in Cygwin bash (our appveyor env), but fails in Git Bash, which is what's used in the Github Actions environment. I could reproduce the same failures on my local windows machine. It looks like there may be some additional, unexpected linebreaks in the windows case. I can file more details about that.filed in #408