Missing arguments in transcode_into convenience APIs
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two instance of `transcode_into` are not passing the `__output` down to the lower-level APIs.
ThePhD
added a commit
that referenced
this pull request
Apr 22, 2021
- 🎨 Improvements to the constexpr processing - ✨ Added __clang_literal_encoding__ and __clang_wide_literal_encoding__ understanding - ✔ Vastly improved endianess tests - 🔨 Fixed up tests for different platforms and for certain compiler errors - 📝Write up a bit better documentations for some portions, fix inline shenanigans (Closes #9) - ✨ Add a CONTRIBUTING file - 🔨 Fix reconstructibility and noexceptness related to certain kinds of iterators (Closes and Fixes #11 and #12) - 📝 Make sure commercial vs. non-commercial is specified more clearly in the LICENSE file
|
In the last mega commit, we fixed this (and a host of other issues). Thanks for pointing it out! Sorry it took a while to get back to you. Let us know if things are okay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two instance of
transcode_intoare not passing the__outputdown to the lower-level APIs.