♻ Slightly refactor CMake to rely more on generator expressions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
♻ Use target_compile_features instead of passing a flag directly ♻ Check several compiler flags before using them ♻ Include CTest instead of calling `enable_testing()` directly ♻ Clean up creation of `scratch` target 🔥 Delete erroneous `include` to pull in sol2-targets in ztd.text-config.cmake.in
CMP0092 Removes the default MSVC warning flags from `CMAKE_<LANG>_FLAGS`, which allows us to remove the `string(REGEX REPLACE)` call
ThePhD
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional notes from the commit
enable_testing()directlyscratchtargetincludeto pull in sol2-targets in ztd.text-config.cmake.inThere are several more changes that could be made to improve ztd.text, including setting up the
install()command, removing the unnecessary exporting of CMake variables (this isn't needed since 2.8).Additionally, CMake supports naming interface libraries with
::in them. As such creating anALIASlibrary is unnecessary and the library could simply be namedztd::text