-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra newline on changes #292
Remove extra newline on changes #292
Conversation
5b787e1
to
1700b0f
Compare
@@ -50,7 +50,7 @@ function changes { | |||
decrypted=$(_decrypt "$path" "0" "0" "$homedir" "$passphrase") | |||
|
|||
# Let's diff the result: | |||
diff_result=$(diff -u <(echo "$decrypted") "$path") || true | |||
diff_result=$(diff -u <(echo -n "$decrypted") "$path") || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Earlier versions used echo for both decryped
and current
... so did not show a diff because both had the extra newline. The switch to using $path
rather than echo-ing the content is what surfaced this issue.
@BrandonCsSanders can you please re-create this branch based on the master branch? |
1700b0f
to
8789269
Compare
done |
8789269
to
9c062ec
Compare
|
I figured out the issue, it is explained in #291 |
Closing this PR as this issue is fixed in #293 |
What does this implement/fix? Explain your changes.
Fixes #291
Does this close any currently open issues?
#291