Add -d option to hide command to remove unencrypted files. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested changes
Feb 11, 2017
src/commands/git_secret_hide.sh
Outdated
|
|
||
| if [[ ! -z "$verbose" ]]; then | ||
| echo | ||
| fi |
There was a problem hiding this comment.
One space is missing here. Indentation is broken.
tests/test_hide.bats
Outdated
| @@ -31,12 +31,19 @@ function teardown { | |||
| } | |||
|
|
|||
|
|
|||
| @test "run 'hide' with params" { | |||
| @test "run 'hide' with params -c" { | |||
There was a problem hiding this comment.
Could you please rename these test to: "run 'hide' with -c param" and
tests/test_hide.bats
Outdated
| run git secret hide -v -c | ||
| [ "$status" -eq 0 ] | ||
| } | ||
|
|
||
|
|
||
| @test "run 'hide' with params -d" { |
|
Thanks for your idea and implementation! I appreciate it. Nice work! |
|
Thanks for the suggestions, I've force pushed the fixes. |
sobolevn
approved these changes
Feb 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option -d to the git secret hide command to remove the unencrypted files after encryption. I often forget to git clean -fX and leave the unencrypted files in my repo.
Tested on Ubuntu 16.10 with bash (4.3.36) & zsh (5.2) & shellcheck (0.4.4).