Skip to content

Conversation

mikhail-akimov
Copy link
Collaborator

@mikhail-akimov mikhail-akimov commented Sep 26, 2018

Added the ability to receive a short version of the commit.
Closes #10

@coveralls
Copy link

coveralls commented Sep 26, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 90a10a6 on mikhail-akimov:Issue-8 into 23172f3 on sobolevn:master.

@mikhail-akimov
Copy link
Collaborator Author

I think it's not compleate. Let me tune it.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! Some changes are required.

@mikhail-akimov
Copy link
Collaborator Author

I getting short=False twice (1-st in parse() and second at _commit_hash() as default value). Can i optimize it somehow?

@sobolevn
Copy link
Member

@mikhail-akimov remove the default value from _commit_hash function.

@sobolevn sobolevn merged commit 0d17c11 into wemake-services:master Sep 27, 2018
@sobolevn
Copy link
Member

@mikhail-akimov awesome work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants