-
-
Notifications
You must be signed in to change notification settings - Fork 4
pyproject.toml inited #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mikhail-akimov thanks! That's a good starting point.
No, currently there's no automated way to do it.
We just copy everything we need from
No, you do not need to. There's only one dependency: https://github.com/sobolevn/jinja2-git/blob/master/setup.py#L13
Yes, we also need to install the dev-dependencies via Please, note that we do not need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a WIP.
I did not understand what "Please, note that we do not need delegator." and "This is a WIP" means? |
There was a dependency called
It means that this pull request is "work in progress". So, it is not yet ready to be merged. |
pyproject.lock was added
Hello! I finished the work on the issue (as i think :)). Did I do the right thing? Can I somehow influence the fact that Travis rejects my last commit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your time and effort.
I will merge this, but keep in mind that these changes break the CI. We will have to fix it in the next task. |
Since I only understand this functionality, I do not quite understand, is there an automated way to migrate from setup.py to poetry?
What is the correct action algorithm?
Do I need to install the application Jinja2_git to identify its dependencies for poetry?
Do I fill the dev-dependencies or not?
The range of the version of python, it turns out, is python = "~2.7 || ^3.6" (is it straight from the original poetry / pyproject.toml)?