Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hmmlist parameter in nextflow_schema.json #37

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Fix hmmlist parameter in nextflow_schema.json #37

merged 2 commits into from
Jun 20, 2023

Conversation

robsyme
Copy link

@robsyme robsyme commented Jun 20, 2023

This commit changes the hmmlist parameter from type "array" to type "string". This fix also lists all of the options so that they can be selected from a drop-down menu in the Tower parameter GUI.

@robsyme
Fix hmmlist parameter in nextflow_schema.json
6767c38 
Before the fix, this parameter was of type "array", and the options were
not provided. This fix changes the type to "string" and provides all of
the options so that they can be selected from a drop-down menu in the
Tower parameter GUI.

Signed-off-by: Rob Syme <rob.syme@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@robsyme
Copy link
Author

robsyme commented Jun 20, 2023

recheck

@robsyme
Prettier check
3056ae9 
Signed-off-by: Rob Syme <rob.syme@gmail.com>
@chasemc
Copy link
Contributor

chasemc commented Jun 20, 2023

Awesome. Thanks!
@robsyme Can you reply in a comment with I have read the CLA Document and I hereby sign the CLA if you can? I will try to make that instruction clearer as well

@robsyme
Copy link
Author

robsyme commented Jun 20, 2023

I have read the CLA Document and I hereby sign the CLA

@chasemc
Copy link
Contributor

chasemc commented Jun 20, 2023

Also not all the GitHub Actions are working yet so don't worry about that

github-actions bot added a commit that referenced this pull request Jun 20, 2023
@github-actions
@robsyme has signed the CLA in #37
f20714e
@chasemc
Copy link
Contributor

chasemc commented Jun 20, 2023

Thanks again

@robsyme
Copy link
Author

robsyme commented Jun 20, 2023

No worries at all. Hope the fix helps!

@chasemc chasemc merged commit 9a78745 into socialgene:dev Jun 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2023
@chasemc
Copy link
Contributor

chasemc commented Jun 20, 2023

For @chasemc; Just so I remember later...
We discussed on nf-core slack. This does fix the issue in Tower but only allows selecting a single HMM database input. For now I'll keep the previous implementation (broken Tower) so that multiple DBs can be input. Will revisit alt solutions later. Rebased and put this commit on a new branch "not_pulled_in_fixes_tower_breaks_functionality" to be kept around until decision is made

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robsyme @chasemc