Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Push converted tags to ocean-d2 repo #100

Merged

Conversation

llucax
Copy link
Member

@llucax llucax commented May 5, 2017

No description provided.

@llucax llucax mentioned this pull request May 5, 2017
@llucax llucax force-pushed the ocean-d2 branch 3 times, most recently from c44fc06 to ac32881 Compare May 5, 2017 10:27
@oraby
Copy link

oraby commented May 5, 2017

LGTM, I've tested it on a local repo and it works as expected.
Let's wait for a bit to see if we should include dub information as well or we'd leave it for a later time.

On unrelated note, I was reading about SemVer to see why you used +d2.auto and it turned out that you are adding metdata, so all is good. However, it mentions that the hyphen character should be added for pre-releases. but we use it for -preview which is actually more of "end-of-life" support. Made we should use +preview in the future instead.

@oraby
Copy link

oraby commented May 5, 2017

On unrelated note, I was reading about SemVer to see why you used +d2.auto and it turned out that you are adding metdata, so all is good. However, it mentions that the hyphen character should be added for pre-releases. but we use it for -preview which is actually more of "end-of-life" support. Made we should use +preview in the future instead.

Oh crap, I should read your message to the end in the future :p, you've just mentioned something similar in #84

@oraby
Copy link

oraby commented May 5, 2017

An extra thought: if we want to add dub and modified README then one way to do it is still to add a a sync branch in the d2 repo and we can change the after-success.sh to basically download the latest version of convert code as in here for example.
If we'd do that then we'd add the sync branch commit hash in the commit message.

@llucax
Copy link
Member Author

llucax commented May 5, 2017

However, it mentions that the hyphen character should be added for pre-releases. but we use it for -preview which is actually more of "end-of-life" support. Made we should use +preview in the future instead.

-preview was only done when this wasn't the real upstream repo for the main development. The tag was fine because the idea was to mark this as a pre-release, since nobody was actually using these tags. Now that the development was moved here, we should completely forget about -preview tags.

@llucax
Copy link
Member Author

llucax commented May 5, 2017

An extra thought: if we want to add dub and modified README then one way to do it is still to add a a sync branch in the d2 repo and we can change the after-success.sh to basically download the latest version of convert code as in here for example.

For me this is too much complexity. If we want to add a dub file (I wouldn't add a readme file), we can just include it as part of the script.

@llucax
Copy link
Member Author

llucax commented May 5, 2017

Updated to use a more complex but secure method for authentication (if the user/password are included in the URL, any errors or messages from Git will reveal the credentials).

@llucax llucax force-pushed the ocean-d2 branch 3 times, most recently from a2e4718 to 391e443 Compare May 5, 2017 13:01
@llucax llucax changed the title [RFC] travis: Push converted tags to ocean-d2 repo travis: Push converted tags to ocean-d2 repo May 5, 2017
@llucax
Copy link
Member Author

llucax commented May 5, 2017

I did a quick try and it seems to work, we'll just need to test the credentials + travis integration in practice though.

@oraby
Copy link

oraby commented May 5, 2017

Here's my go at dub.json:

{
    "name": "ocean-d2",
    "description": "Auto convert of ocean-d1 library. Ocean is general purpose library with a focus on supporting the development of high-performance, real-time applications.",
    "authors": ["Sociomantic Labs GmbH "],
    "homepage": "https://github.com/sociomantic-tsunami/ocean",
    "license": "BSD 3-clause or Check Ocean License",
    "copyright": "Copyright (c) 2004-2017 Sociomantic Labs GmbH and Tango contributors.\nAll rights reserved.",
    "systemDependencies": "Depending on the component used you might need one of the following libraries:\n-lglib-2.0 -lpcre -lxml2 -lxslt -lebtree -lreadline -lhistory -llzo2 -lbz2 -lz -ldl -lgcrypt -lgpg-error -lrt.\nNotice that the used -lebtree comes from https://github.com/sociomantic-tsunami/ebtree",
    "importPaths": ["src/"],
    "targetType": "sourceLibrary"
}

@llucax
Copy link
Member Author

llucax commented May 5, 2017

"name": "ocean-d2",

Any reason not to use just "ocean"?

"homepage": "https://github.com/sociomantic-tsunami/ocean",

And here use ocean-d2, as it is from where the code really comes?

@oraby
Copy link

oraby commented May 5, 2017

Any reason not to use just "ocean"?

Basically I want to reserve the ocean name for when we move this (ocean-d1) repo to be full d2 repo.

"homepage": "https://github.com/sociomantic-tsunami/ocean",

As far as I understand, that needs to be the project homepage. That can be the read-the-docs or something. So I thought to add the mian-repo as the homepage as it's where all the development happens.

@llucax
Copy link
Member Author

llucax commented May 6, 2017

Basically I want to reserve the ocean name for when we move this (ocean-d1) repo to be full d2 repo.

👍

As far as I understand, that needs to be the project homepage. That can be the read-the-docs or something. So I thought to add the mian-repo as the homepage as it's where all the development happens.

I think this might be a bit confusing, it should be clearer to the user to send them to the page that explains they are using an automated conversion of a project, not really the project itself.

@llucax
Copy link
Member Author

llucax commented May 6, 2017

I just pushed an update adding the dub file, I converted it to .sdl and changed the URL, but we can keep discussing the URL :)

@llucax llucax force-pushed the ocean-d2 branch 3 times, most recently from ebecfa6 to f54bd0d Compare May 6, 2017 11:33
@@ -0,0 +1,9 @@
name "ocean-d2"
description "Auto convert of ocean-d1 library. Ocean is general purpose library with a focus on supporting the development of high-performance, real-time applications."
authors "Sociomantic Labs GmbH "
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space after GmbH

@llucax llucax force-pushed the ocean-d2 branch 2 times, most recently from 6dbeaef to c80d89d Compare May 6, 2017 15:00
@llucax
Copy link
Member Author

llucax commented May 6, 2017

Pushed new updated, I reverted the URL because DUB already shows the repo URL, so putting the original project seems reasonable.

@llucax
Copy link
Member Author

llucax commented May 6, 2017

OK, we already sort of pushed this online for Hatem's lighting talk, so I will merge. Let's see how it works next time we tag something.

FYI @gavin-norman-sociomantic @mihails-strasuns-sociomantic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants