-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis: Push converted tags to ocean-d2 repo #100
travis: Push converted tags to ocean-d2 repo #100
Conversation
c44fc06
to
ac32881
Compare
LGTM, I've tested it on a local repo and it works as expected. On unrelated note, I was reading about SemVer to see why you used |
Oh crap, I should read your message to the end in the future :p, you've just mentioned something similar in #84 |
An extra thought: if we want to add dub and modified README then one way to do it is still to add a a sync branch in the d2 repo and we can change the |
|
For me this is too much complexity. If we want to add a dub file (I wouldn't add a readme file), we can just include it as part of the script. |
Updated to use a more complex but secure method for authentication (if the user/password are included in the URL, any errors or messages from Git will reveal the credentials). |
a2e4718
to
391e443
Compare
I did a quick try and it seems to work, we'll just need to test the credentials + travis integration in practice though. |
Here's my go at {
"name": "ocean-d2",
"description": "Auto convert of ocean-d1 library. Ocean is general purpose library with a focus on supporting the development of high-performance, real-time applications.",
"authors": ["Sociomantic Labs GmbH "],
"homepage": "https://github.com/sociomantic-tsunami/ocean",
"license": "BSD 3-clause or Check Ocean License",
"copyright": "Copyright (c) 2004-2017 Sociomantic Labs GmbH and Tango contributors.\nAll rights reserved.",
"systemDependencies": "Depending on the component used you might need one of the following libraries:\n-lglib-2.0 -lpcre -lxml2 -lxslt -lebtree -lreadline -lhistory -llzo2 -lbz2 -lz -ldl -lgcrypt -lgpg-error -lrt.\nNotice that the used -lebtree comes from https://github.com/sociomantic-tsunami/ebtree",
"importPaths": ["src/"],
"targetType": "sourceLibrary"
}
|
Any reason not to use just "ocean"?
And here use ocean-d2, as it is from where the code really comes? |
Basically I want to reserve the
As far as I understand, that needs to be the project homepage. That can be the read-the-docs or something. So I thought to add the mian-repo as the homepage as it's where all the development happens. |
👍
I think this might be a bit confusing, it should be clearer to the user to send them to the page that explains they are using an automated conversion of a project, not really the project itself. |
I just pushed an update adding the dub file, I converted it to |
ebecfa6
to
f54bd0d
Compare
ci/ocean-d2-dub.sdl
Outdated
@@ -0,0 +1,9 @@ | |||
name "ocean-d2" | |||
description "Auto convert of ocean-d1 library. Ocean is general purpose library with a focus on supporting the development of high-performance, real-time applications." | |||
authors "Sociomantic Labs GmbH " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra space after GmbH
6dbeaef
to
c80d89d
Compare
Pushed new updated, I reverted the URL because DUB already shows the repo URL, so putting the original project seems reasonable. |
OK, we already sort of pushed this online for Hatem's lighting talk, so I will merge. Let's see how it works next time we tag something. |
No description provided.