Don't process socket.connect() if we are already re-connecting. #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason why this PR is still not merged? |
DivineThreepwood
added a commit
to openbase/bco.app
that referenced
this pull request
Nov 23, 2019
|
It's a pity useful PRs don't get merged anymore. :( |
|
@KushtrimPacaj sorry for the delay, thanks a lot for this. @DivineThreepwood @GingerAdonis is there anything else you'd like to see merged/fixed? |
ssalonen
added a commit
to ssalonen/openhab-osgiify
that referenced
this pull request
Aug 23, 2021
Specifically looking for the fix PR socket.io-client-java#577 This might help with reconnection issues, as mentioned in PR "it is breaking re-connection in some edge cases". socketio/socket.io-client-java#577 https://socketio.github.io/socket.io-client-java/changelog.html Signed-off-by: Sami Salonen <ssalonen@gmail.com>
wborn
pushed a commit
to openhab/openhab-osgiify
that referenced
this pull request
Oct 11, 2021
Specifically looking for the fix PR socket.io-client-java#577 This might help with reconnection issues, as mentioned in PR "it is breaking re-connection in some edge cases". socketio/socket.io-client-java#577 https://socketio.github.io/socket.io-client-java/changelog.html Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nkzawa Fixes #576 .
I opted to not allow the socket.connect call to proceed if we're in re-connecting mode, because it is breaking re-connection in some edge cases.
The alternative would be to cancel reconnection, try to connect, and if failed, allow reconnection. While this option will make sure that a re-connection try happens whenever .connect() is called, and disregard the timer, it's more messy to code.
And I think that the first option is good enough, since the default max re-connection try is 5000ms