Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer is deprecated fix #3481

Merged
merged 2 commits into from Sep 20, 2019
Merged

Buffer is deprecated fix #3481

merged 2 commits into from Sep 20, 2019

Conversation

flaambe
Copy link
Contributor

@flaambe flaambe commented Aug 21, 2019

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

Buffer() is deprecated warning message in test

New behaviour

No warning message in test

Other information (e.g. related issues)

@darrachequesne darrachequesne merged commit 4d01b2c into socketio:master Sep 20, 2019
1 check passed
@darrachequesne
Copy link
Member

darrachequesne commented Sep 20, 2019

@flaambe great, thanks 👍

@flaambe flaambe deleted the fix-buffer-deprecated branch Sep 20, 2019
@darrachequesne darrachequesne added this to the 2.3.0 milestone Sep 28, 2020
This was referenced Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants