Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5034 - change private property io.httpServer to a public property #5035

Merged
merged 3 commits into from
May 27, 2024

Conversation

tnfAngel
Copy link
Contributor

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behavior

import { Server } from "socket.io";

const io = new Server(3000, { /* options */ });

io.httpServer // Property 'httpServer' is private and only accessible within class 'Server<ListenEvents, EmitEvents, ServerSideEvents, SocketData>'.ts(2341)

New behavior

import { Server } from "socket.io";

const io = new Server(3000, { /* options */ });

io.httpServer // now is accessible as the documentations says (https://socket.io/docs/v4/server-initialization/#standalone)

Other information (e.g. related issues)

#5034

@darrachequesne darrachequesne merged commit 31f10f6 into socketio:main May 27, 2024
12 checks passed
@darrachequesne
Copy link
Member

Good catch, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants