Introduce Async::Redis::Endpoint.
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ioquatix
force-pushed
the
redis-endpoint
branch
from
29ad229
to
de2b449
Compare
lib/async/redis/endpoint.rb
Outdated
| # @option hostname [String] the hostname to connect to (or bind to), overrides the URL hostname (used for SNI). | ||
| # @option port [Integer] the port to bind to, overrides the URL port. | ||
| # @option ssl_context [OpenSSL::SSL::SSLContext] the context to use for TLS. | ||
| # @option alpn_protocols [Array<String>] the alpn protocols to negotiate. |
There was a problem hiding this comment.
Q: Should url, endpoint be documented (in the docblock)?
There was a problem hiding this comment.
The documentation was kind of messed up. Fixed. Thanks for calling it out.
- Handles authentication and database selection.
ioquatix
force-pushed
the
redis-endpoint
branch
from
de2b449
to
31814b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the existing authentication and database selection protocols.
Introduces a proper foundation for socketry/async-job-processor-redis#1 and perhaps sentinels.
Types of Changes
Contribution