Detect fallback local loopback address correctly #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@repeatedly sorry for missing another test case, could you review, please? |
In the previous PR, socketry#71, local loopback address is detected even though hosts file is empty, but there is a case that hosts file is NOT empty and localhost entry is missing. In such a case, Coolio::DNSResolver.hosts("localhost") does not work as expected. This PR should fix such case.
ioquatix
force-pushed
the
fix-missing-localhost
branch
from
9c2285d
to
db442e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous PR, #71, local loopback address is
detected even though hosts file is empty, but
there is a case that hosts file is NOT empty
and localhost entry is missing. In such a case,
Coolio::DNSResolver.hosts("localhost") does not work
as expected. This PR should fix such case.