Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroku example for the Deployment Guide #235

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

trevorturk
Copy link
Contributor

@trevorturk trevorturk commented Apr 11, 2024

Re: socketry/falcon-rails-example#1, adding some documentation to show a full working example Heroku configuration for Falcon.

Note I wasn't sure where to put this, but I believe this could be a reasonable place. I also tried to follow the new configuration style in the guides, but feedback is welcome.

Note also that I included preload, cache, and count config examples which may or may not be desirable. I'm happy to adjust. We could also adjust to use a different ENV var etc as opposed to FALCON_COUNT -- feel free to adjust as you like, or let me know what you'd prefer and I'll make adjustments.

Fixes #189
Fixes #121

Types of Changes

  • Documentation.

Contribution

@ioquatix
Copy link
Member

This looks great to me.

For all the major configuration options you've listed, it would be great to explain what it does, and how to use it.

@trevorturk
Copy link
Contributor Author

trevorturk commented Apr 15, 2024

Ok, I made some updates. Let me know what you think! I added some more info and links. I changed FALCON_COUNT to WEB_CONCURRENCY since this is what most people use for Puma, but let me know what you think. I also removed cache false because from my testing it appears that the cache is disabled by default now. (Is that right? I thought I remembered it being enabled by default, which I found surprising, but perhaps we disabled it by default now?) I also tagged this as fixing a couple old related issues I found.

@ioquatix ioquatix merged commit 3fad7ef into socketry:main Apr 16, 2024
45 of 46 checks passed
@ioquatix
Copy link
Member

Thanks, this looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide an example falcon.rb setup for Rails (migrating from Puma) falcon hosting on heroku using falcon.rb
2 participants