generate socket.ini documentation #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chicoxyzzy
requested review from
heapwolf,
jwerle and
mribbons
and removed request for
heapwolf
chicoxyzzy
changed the title
chicoxyzzy
commented
Apr 18, 2023
| @@ -1277,7 +1269,6 @@ int main (const int argc, const char* argv[]) { | |||
| } | |||
|
|
|||
| settings["debug"] = flagDebugMode; | |||
| settings["build_suffix"] = suffix; | |||
Comment on lines
-176
to
-181
| if (androidHome.size() == 0) { | ||
| androidHome = settings["android_" + platform.os + "_home"]; | ||
| } | ||
|
|
||
| if (androidHome.size() == 0) { | ||
| androidHome = settings["android_home"]; |
There was a problem hiding this comment.
removed in favor of .ssc.env and .sscrc
Comment on lines
-2448
to
-2451
| if (settings.count("deb_name") == 0) { | ||
| settings["deb_name"] = settings["build_name"]; | ||
| } | ||
|
|
There was a problem hiding this comment.
just use build_name in the deb template
|
@chicoxyzzy Can you rebase to |
jwerle
approved these changes
Apr 21, 2023
heapwolf
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undocumented stuff from config:
"android_" + platform.os + "_home"android_homeandroid_enable_standard_ndk_buildandroid_skip_gradleandroid_build_socket_runtimeandroid_main_activityandroid_sdk_manager_pathandroid_aapt_no_compressandroid_aapt(undocumented)android_native_abisandroid_ndk_abi_filters(undocumented)android_manifest_permissionsandroid_allow_cleartextandroid_default_config_external_native_buildandroid_external_native_buildandroid_native_cflagsandroid_native_sourcesandroid_native_makefileandroid_sourcesandroid_sdk_manager_pathios_provisioning_specifierios_provisioning_profileios_codesign_identityapple_team_idapple_instrumentsheadless_runnerheadless_runner_flags"headless_" + platform.os + "_runner""headless_" + platform.os + "_runner_flags"build_suffixlinux_executable_pathdeb_namewin_versionexemac_signmac_sign_paths