Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApplicationURLEvent #841

Merged
merged 54 commits into from
Dec 13, 2023
Merged

ApplicationURLEvent #841

merged 54 commits into from
Dec 13, 2023

Conversation

jwerle
Copy link
Member

@jwerle jwerle commented Dec 11, 2023 •
edited
Loading

Closes #790
Closes #568

@jwerle jwerle added enhancement New feature or request windows android javascript An issue, discussion, or task related to the runtime javascript api An issue, task, or discussion related to public runtime APIs linux An issue, task, or pull request related to linux ios An issue, task, or pull request related to iOS macos An issue, task, or discussion related to macOS runtime An issue, task, or discussion related to the runtime core labels Dec 11, 2023
@jwerle jwerle self-assigned this Dec 11, 2023
heapwolf
heapwolf approved these changes Dec 11, 2023
View reviewed changes
src/android/main.kt Outdated Show resolved Hide resolved
@jwerle jwerle force-pushed the application-url-hook branch 2 times, most recently from 9d5ace1 to 2520eb0 Compare December 11, 2023 21:40
chicoxyzzy
chicoxyzzy reviewed Dec 11, 2023
View reviewed changes
src/cli/cli.cc Outdated Show resolved Hide resolved
chicoxyzzy
chicoxyzzy reviewed Dec 11, 2023
View reviewed changes
src/desktop/main.cc Outdated Show resolved Hide resolved
src/android/main.kt Outdated Show resolved Hide resolved
src/cli/templates.hh Show resolved Hide resolved
chicoxyzzy
chicoxyzzy reviewed Dec 11, 2023
View reviewed changes
src/desktop/main.cc Outdated Show resolved Hide resolved
chicoxyzzy
chicoxyzzy suggested changes Dec 11, 2023
View reviewed changes
Copy link
Member

@chicoxyzzy chicoxyzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS build fails, see my comments above

@jwerle jwerle marked this pull request as ready for review December 12, 2023 23:47
chicoxyzzy
chicoxyzzy approved these changes Dec 13, 2023
View reviewed changes
src/cli/cli.cc
@@ -2022,7 +2022,7 @@ int main (const int argc, const char* argv[]) {
settings["build_name"] + "_" +
"v" + settings["meta_version"] + "-" +
settings["meta_revision"] + "_" +
replace(platform.arch, "x86_64", "amd64")
replace(SSC::platform.arch, "x86_64", "amd64")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just linking #568 here, so we don't forget to fix it here later as well

src/cli/cli.cc Show resolved Hide resolved
@jwerle jwerle merged commit 9e97c5c into master Dec 13, 2023
2 checks passed
@jwerle jwerle deleted the application-url-hook branch December 13, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chicoxyzzy chicoxyzzy chicoxyzzy approved these changes

@bcomnes bcomnes bcomnes approved these changes

@heapwolf heapwolf heapwolf approved these changes

Assignees

@jwerle jwerle

Labels
android api An issue, task, or discussion related to public runtime APIs enhancement New feature or request ios An issue, task, or pull request related to iOS javascript An issue, discussion, or task related to the runtime javascript linux An issue, task, or pull request related to linux macos An issue, task, or discussion related to macOS runtime An issue, task, or discussion related to the runtime core windows
Projects
None yet
Milestone
No milestone
4 participants
@jwerle @heapwolf @bcomnes @chicoxyzzy