Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom webview headers and applinks #915

Merged
merged 14 commits into from
Feb 4, 2024

Conversation

jwerle
Copy link
Member

@jwerle jwerle commented Feb 4, 2024

Closes #871

This enables setting custom HTTP headers for all navigator requests where

[webview]
headers[] = "X-Custom-Header: some-value"

will be made available in all requests made in the webview.

@jwerle jwerle added enhancement New feature or request windows android config An issue, discussion, or pull request related to application config linux An issue, task, or pull request related to linux ios An issue, task, or pull request related to iOS macos An issue, task, or discussion related to macOS runtime An issue, task, or discussion related to the runtime core labels Feb 4, 2024
@jwerle jwerle requested a review from heapwolf February 4, 2024 00:28
@jwerle jwerle self-assigned this Feb 4, 2024
@jwerle jwerle force-pushed the custom-webview-headers-and-applinks branch from 3190791 to 61c4cf3 Compare February 4, 2024 14:10
src/cli/cli.cc Outdated Show resolved Hide resolved
@@ -267,7 +267,7 @@ constexpr auto gMacOSInfoPList = R"XML(<?xml version="1.0" encoding="UTF-8"?>
<string>MainMenu</string>

<key>NSPrincipalClass</key>
<string>AtomApplication</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧐

@jwerle jwerle merged commit 9b1e701 into master Feb 4, 2024
2 checks passed
@jwerle jwerle deleted the custom-webview-headers-and-applinks branch February 4, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android config An issue, discussion, or pull request related to application config enhancement New feature or request ios An issue, task, or pull request related to iOS linux An issue, task, or pull request related to linux macos An issue, task, or discussion related to macOS runtime An issue, task, or discussion related to the runtime core windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support configurable window navigation response headers
2 participants