Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix .plan method #18

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix .plan method #18

merged 1 commit into from
Sep 29, 2023

Conversation

nichoth
Copy link
Contributor

@nichoth nichoth commented Sep 29, 2023 •
edited
Loading

It's better this way because we check if _planned exists, which is what we care about. Fixes the scenario where you plan for tests but never make any assertions.

@nichoth nichoth mentioned this pull request Sep 29, 2023
Merged
@nichoth nichoth changed the title better style Fix .plan method Sep 29, 2023
bcomnes
bcomnes approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@bcomnes bcomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice catch.

@bcomnes bcomnes merged commit b21f97d into socketsupply:master Sep 29, 2023
1 check passed
@bcomnes
Copy link
Contributor

bcomnes commented Sep 29, 2023

https://www.npmjs.com/package/@socketsupply/tapzero/v/0.8.0

@bcomnes bcomnes self-assigned this Sep 29, 2023
@nichoth nichoth deleted the test-end branch October 1, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chicoxyzzy chicoxyzzy chicoxyzzy approved these changes

@bcomnes bcomnes bcomnes approved these changes

@heapwolf heapwolf Awaiting requested review from heapwolf

Assignees

@bcomnes bcomnes

@nichoth nichoth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nichoth @bcomnes @chicoxyzzy