check for a valid iframe.contentWindow inside the timeout call #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
address a possible race condition where the call to the iframe's postMessage can happen after the frame has been closed. The initial check can succeed, but the call happens 'later' and it is possible for the frame to be closed.
|
Seems like the outside |
|
I would also love it if you can add a test that exposes this bug. |
|
removing the outer if statement was something I pondered. So yes. Let me clean that up. Regarding a test, happy to do that too. This is a timing issue. Is there a similar test that I could look at for guidance? |
|
I don't think there are good examples of tests that expose timing issues. I'm happy to help if you get stuck. |
|
The race condition happens in my project unfortunately after updating to version 1.0 from 0.3.4. It happened when the connection failed and its calling stack can be found at http://pasteboard.co/19Su0QWU.png |
|
That just happened just when the web-socket handshaking failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address a possible race condition where the call to the iframe's postMessage can happen after the frame has been closed. The initial check can succeed, but the call happens 'later' and it is possible for the frame to be closed.