Sockjs 1.03 not running on IE8/IE7 browsers since apply method missing #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
does not have an apply function. using try catch we are take care that everything works. tested on IE8.
|
I'm still having issues with IE8 in certain cases, but this was an error that prevented anything from running. |
|
Interesting that IE8 throws an error. This exact code is meant to detect if |
|
What was the error that was thrown? Can you also fix the indentation? |
|
The error that I was getting is: "Object doesn't support this action" In IE8 and earlier, if a property does not exist an exception is thrown |
|
Ok. It looks like you changed to either 4 space indentation or tabs. It should be 2 space indentation. Sorry to be so picky. |
|
lol, got it :) |
brycekahle
added a commit
that referenced
this pull request
Jan 5, 2016
Sockjs 1.03 not running on IE8/IE7 browsers since apply method missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added fix for old browsers such as IE7/8 were console.log
does not have an apply function.
using try catch we are take care that everything works.
tested on IE8/IE7 via Edge (IE11).
Fixes #276