Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger API yaml addition #123

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

sushanthakumar
Copy link
Collaborator

@sushanthakumar sushanthakumar commented Dec 4, 2022

Signed-off-by: sushanthakumar sushanthakumar@huawei.com

What type of PR is this?
kind documentation

What this PR does / why we need it:
This PR adds the swagger files containing Kahu APIs that can be executed by users

Which issue(s) this PR fixes:

Fixes #

Test Report Added?:
kind TESTED

Test Report:
API List:
Selection_999(141)

Selection_999(142)

Special notes for your reviewer:

joseph-v
joseph-v previously approved these changes Dec 5, 2022
Copy link
Collaborator

@AmitRoushan AmitRoushan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, swagger file can be part of docs. Also Kahu API version should be v1beta1.

Signed-off-by: sushanthakumar <sushanthakumar@huawei.com>
Copy link
Collaborator

@AmitRoushan AmitRoushan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AmitRoushan AmitRoushan merged commit cdddc44 into soda-cdm:development Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants